One should ask for worldly success as well as the success of the hereafter. Several of the supplications in the Quran as well as those taught by Prophet Muhammad SAW do the same.

فَإِذَا قَضَيْتُم مَّنَاسِكَكُمْ فَاذْكُرُواْ اللّهَ كَذِكْرِكُمْ آبَاءكُمْ أَوْ أَشَدَّ ذِكْرًا فَمِنَ النَّاسِ مَن يَقُولُ رَبَّنَا آتِنَا فِي الدُّنْيَا وَمَا لَهُ فِي الآخِرَةِ مِنْ خَلاَقٍ وِمِنْهُم مَّن يَقُولُ رَبَّنَا آتِنَا فِي الدُّنْيَا حَسَنَةً وَفِي الآخِرَةِ حَسَنَةً وَقِنَا عَذَابَ النَّارِ أُولَـئِكَ لَهُمْ نَصِيبٌ مِّمَّا كَسَبُواْ وَاللّهُ سَرِيعُ الْحِسَابِ

“[And this also is necessary that] after this when you have fulfilled the rites of Hajj, remember God as you remember your forefathers; in fact even more. [This is the time of asking from God] but there are some who [at this instance also] say: ‘Lord, give us in this world’ and [then the result of this is that] they shall have no share in the world to come. But there are others who say: ‘Lord, give us what is good both in this world and in the world to come, and save us from the torment of the Fire’. It is these who will receive a share of what they earned and swift is God in taking account”. (Quran 2:200-202)

(Excerpt from Quranic Exegesis: Javed Ahmed Ghamidi)

(Translated by Dr. Shehzad Saleem)